feat: removed old my-expenses page (deprecation) #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julias0
reviewed
Mar 11, 2024
| @@ -23,3 +23,13 @@ export type ReportFilters = Partial<{ | |||
| cardNumbers: string[]; | |||
| splitExpense: string; | |||
| }>; | |||
|
|
|||
| export interface ExpenseFilters extends Omit<Filters, 'state'> { | |||
There was a problem hiding this comment.
one interface per file
Can you check if there is a eslint rule for this? We should enforce this
Julias0
approved these changes
Mar 11, 2024
* feat: removed old my-expenses page (deprecation) - Part 2 * feat: removed old my-expenses page (deprecation) - Part 3 (#2816) * feat: removed old my-expenses page (deprecation) - Part 3 * feat: removed old my-expenses page (deprecation) - Part 4 (#2817) * feat: removed old my-expenses page (deprecation) - Part 4 * fix: correction in card filters logic (#2818)
…action-my-expenses-1
|
suyashpatil78
added a commit
that referenced
this pull request
Mar 12, 2024
* feat: removed old my-expenses page (deprecation) * feat: removed old my-expenses page (deprecation) - Part 2 (#2815) * feat: removed old my-expenses page (deprecation) - Part 2 * feat: removed old my-expenses page (deprecation) - Part 3 (#2816) * feat: removed old my-expenses page (deprecation) - Part 3 * feat: removed old my-expenses page (deprecation) - Part 4 (#2817) * feat: removed old my-expenses page (deprecation) - Part 4 * fix: correction in card filters logic (#2818) * major pr comments as well as merge * setting branch coverage to 91%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
copilot:summary
copilot:poem
Walkthrough
copilot:walkthrough
Clickup
app.clickup.com
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes